Skip to content

Add the splat to redirect URL#743

Merged
jetstack-bot merged 2 commits intocert-manager:masterfrom
mattbates:mb/fix-docs-redirect
Nov 3, 2021
Merged

Add the splat to redirect URL#743
jetstack-bot merged 2 commits intocert-manager:masterfrom
mattbates:mb/fix-docs-redirect

Conversation

@mattbates
Copy link
Contributor

@mattbates mattbates commented Nov 2, 2021 •
edited
Loading

This should ensure that the path in the original URL is carried into the redirect URL.

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Nov 2, 2021
@netlify
Copy link

netlify bot commented Nov 2, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: c3c04b0

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/6182694a3781ce0008317dc4

😎 Browse the preview: https://deploy-preview-743--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 2, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Nov 2, 2021

Hi @mattbates. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2021
@mattbates
Add the splat to redirect URL
4ee3b3b 
Signed-off-by: Matthew Bates <mattbates25@gmail.com>
@mattbates mattbates force-pushed the mb/fix-docs-redirect branch from c906219 to 4ee3b3b Compare November 2, 2021 15:40
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Nov 2, 2021
irbekrm
irbekrm reviewed Nov 3, 2021
View reviewed changes
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2021
@mattbates
Add newline
c3c04b0 
Signed-off-by: Matthew Bates <mattbates25@gmail.com>
@irbekrm
Copy link
Contributor

irbekrm commented Nov 3, 2021

Thanks Matt!

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Nov 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, mattbates

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2021
@jetstack-bot jetstack-bot merged commit 6b3fa9a into cert-manager:master Nov 3, 2021
@jetstack-bot jetstack-bot mentioned this pull request Dec 3, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@irbekrm irbekrm irbekrm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@irbekrm irbekrm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattbates @jetstack-bot @irbekrm